Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse timestamp field safely #760

Merged
merged 1 commit into from
Feb 1, 2024
Merged

parse timestamp field safely #760

merged 1 commit into from
Feb 1, 2024

Conversation

vthacker
Copy link
Contributor

@vthacker vthacker commented Feb 1, 2024

Summary

  1. Parse @timestamp first since that should take precendece.
  2. parse timestamp field in a try-catch since we make the assumption it will be a long and in millis

@vthacker vthacker force-pushed the vthacker_timestamp_handling_pt2 branch from 3a26543 to b8e6da6 Compare February 1, 2024 22:01
bryanlb
bryanlb requested changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@bryanlb bryanlb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got an extra test assert to go along with this? 😁

@vthacker vthacker force-pushed the vthacker_timestamp_handling_pt2 branch from b8e6da6 to 4307616 Compare February 1, 2024 23:22
@vthacker vthacker force-pushed the vthacker_timestamp_handling_pt2 branch from 4307616 to edfcf43 Compare February 1, 2024 23:25
@vthacker vthacker merged commit 452c461 into master Feb 1, 2024
3 checks passed
@vthacker vthacker deleted the vthacker_timestamp_handling_pt2 branch February 1, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanlb bryanlb bryanlb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vthacker @bryanlb